search

tgallacher / gatsby-plugin-remove-generator

🕵️‍♀️ Customise or remove the "meta generator" tag on your Gatsby site.
https://npm.im/gatsby-plugin-remove-generator
MIT License
7 stars 2 forks source link

Plugin gatsby-plugin-remove-generator is not compatible with your gatsby version 5.3.2 - It requires gatsby@2.x.x || 3.x.x || 4.x.x #185

Closed danilobuerger closed 1 year ago

danilobuerger commented 1 year ago

When using this plugin I get the following warning message:

Plugin gatsby-plugin-remove-generator is not compatible with your gatsby version 5.3.2 - It requires gatsby@2.x.x || 3.x.x || 4.x.x

arsinclair commented 1 year ago

Can someone add Gatsby v5 support?

There are PRs open since Apr 1, 2022, is this project dead?

danilobuerger commented 1 year ago

Can someone add Gatsby v5 support?

It already works with Gatsby v5. This issue is just about getting the warning message removed.

arsinclair commented 1 year ago

This issue is just about getting the warning message removed

That's only partially true, a dependency tree needs to be updated as well. Currently it doesn't allow gatsby@5 yet, therefore npm install fails. Of course using --force or --legacy-peer-deps arguments isn't desired and will require updating all our CI configurations.

This is what I get when trying to install gatsby-plugin-remove-generator:

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: project-name@1.0.0 npm ERR! Found: gatsby@5.6.0 npm ERR! node_modules/gatsby npm ERR! gatsby@"^5.6.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer gatsby@"2.x.x || 3.x.x || 4.x.x" from gatsby-plugin-remove-generator@1.2.0 npm ERR! node_modules/gatsby-plugin-remove-generator npm ERR! gatsby-plugin-remove-generator@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I'm not so much worried about getting the warning off the way, but rather about updating the dependency tree.

arsinclair commented 1 year ago

Can we have a word from the maintainer? @tgallacher what's your perspective on this? Would you be able to work on this? Would you like me to submit a PR?

tgallacher commented 1 year ago

Can we have a word from the maintainer? @tgallacher what's your perspective on this? Would you be able to work on this? Would you like me to submit a PR?

Happy for PRs!

This plugin isn't dead, I'm just not using GatsbyJS as much as I was. Will keep it alive though!

arsinclair commented 1 year ago

Great, here: https://github.com/tgallacher/gatsby-plugin-remove-generator/pull/192

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: