search

tgdwyer / WebCola

Javascript constraint-based graph layout
http://marvl.infotech.monash.edu/webcola/
MIT License
2.02k stars 258 forks source link

Make WebCola available in bower #24

Closed pigne closed 10 years ago

pigne commented 10 years ago

Hi,

WebCola seems to have a well defined bower.json file, however it does not appear on search results within bower. The project has actually no tags, so it's not possible to get it from bower.

Any reason for not making this happen?

Best.

tgdwyer commented 10 years ago

bollwyvl recently set up our bower.json file as part of a general automation tools makeover. How does one add tags? I didn't even realize it was a package manager!

Thanks!

pigne commented 10 years ago

First, make sure the project is registered with bower : http://bower.io/#registering-packages

Then, tag any commit with a semver name (e.g. git tag v2.0.0) and push it (git push origin --tags).

antitoxic commented 10 years ago

Is there any updates on this. It's nice to have it in bower.

jkschneider commented 10 years ago

I registered the name webcola in bower today, but since it has no semver style tags, there are no releases available :(

I believe if you tag the last release with 3.0.0 instead of v3, versioning support will be immediately available to everyone that uses bower!

That said, bower install webcola does work, but it clones the repo which contains all 3 versions of the minified JS in the WebCola folder, which I think is not what most bower users would expect. A more idiomatic structure would have just one webcola.min.js in a dist folder which varies depending on which semver tag the user is referring to, and therefore the tagged version of that dist in your Git repo.

tgdwyer commented 10 years ago

Thanks for doing this! I did actually make a "v3" tag a little while ago with the intention of setting up bower. I've just created a v3.0.0 tag also, in case that was the problem?

$ git tag v3 v3.0.0

Is there anything else I need to do?

Thanks

Tim

On 21 June 2014 22:52, jkschneider notifications@github.com wrote:

I registered webcola in bower today, but since it has no semver style tags, there are no releases available :(

— Reply to this email directly or view it on GitHub https://github.com/tgdwyer/WebCola/issues/24#issuecomment-46752925.

Dr Tim Dwyer BSc BCS(Hons) PhD Senior Lecturer and Larkins Fellow Caulfield School of Information Technology Mobile: 0481 240 767 (from overseas: +61 481 240 767)

tgdwyer commented 10 years ago

Yep, that's done, and I can see the tags from github:

https://github.com/tgdwyer/WebCola/tree/v3.0.0

Does it work now?

Thanks!

From: Yoann Pigné Sent: ‎Monday‎, ‎23‎ ‎June‎ ‎2014 ‎5‎:‎37‎ ‎PM To: tgdwyer/WebCola Cc: Tim Dwyer

Did you push the tags to the remote? By default tags are only local. git push origin --tags

— Reply to this email directly or view it on GitHub.

jkschneider commented 10 years ago

This does work now, and can be closed.