Oversight: ByteOffset does not update file pointers.

tge-was-taken / p4gpc.modloader

Mod loader for the Steam version of Persona 4 Golden

40 stars 12 forks source link

Oversight: ByteOffset does not update file pointers. #17

Closed Sewer56 closed 2 years ago

Sewer56 commented 2 years ago

When a custom ByteOffset is specified in NtReadFile, the file pointer should be updated to that. It seems I didn't take that into account in the original redirector; and p4gpc.modloader missed it too.

I noticed this bug because I'm working on the universal framework for archive emulation; so get to look over my old code. At lines like this one, effoffset should be used.

Sewer56 commented 2 years ago

Fixed in 20e7740d3f90c631960ee5b6b0f48a83a9e2910b