tgen / pegasusPipe

MIT License
1 stars 0 forks source link

dnaAlignParts.sh doesn't check for R2 Fastq Pass #36

Open denriquez opened 7 years ago

denriquez commented 7 years ago

When large fastqs are split because they are too big, there is no check to see if R2 finished splitting properly. It does check to see if the R2 fastq exists, however, during the last stage of splitting which gzips it, the fastq will exist but will still be in the process of being zipped up.

PedalheadPHX commented 7 years ago

Why are we splitting FASTQ, what is the situation when this occurs? If this is really needed we should be doing at the BCL conversion step @denriquez @tgenahmet @awchrist @ryanrichholt

denriquez commented 7 years ago

We actually talked about this in person before but I don't think you remember. Splitting FASTQ doesn't happen for every FASTQ. This happens when the FASTQ is larger than 36 GB. Also, the project that is going through this step wasn't sequenced here.

PedalheadPHX commented 7 years ago

Is it genomes?


Jonathan Keats Director of Bioinformatics & Assistant Professor Translational Genomics Research Institute

445 North Fifth Street, Phoenix, AZ, 85004 p: 602-343-8690 c: 480-543-0634 jkeats@tgen.org | www.keatslab.org | www.tgen.org

On Jul 27, 2017, at 14:32, denriquez notifications@github.com wrote:

We actually talked about this in person before but I don't think you remember. Splitting FASTQ doesn't happen for every FASTQ. This happens when the FASTQ is larger than 36 GB. Also, the project that is going through this step wasn't sequenced here.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/tgen/pegasusPipe/issues/36#issuecomment-318431765, or mute the thread https://github.com/notifications/unsubscribe-auth/AL1RHE39iPbc4HyRYB8pmVXR8ta66258ks5sSMmZgaJpZM4OkaUQ.

--

This electronic message is intended to be for the use only of the named recipient, and may contain information that is confidential or privileged, including patient health information. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the contents of this message is strictly prohibited. If you have received this message in error or are not the named recipient, please notify us immediately by contacting the sender at the electronic mail address noted above, and delete and destroy all copies of this message. Thank you.

denriquez commented 7 years ago

Yes

PedalheadPHX commented 7 years ago

Can you add a card to the pipeline development trello board about speed optimization and if one task will be testing FASTQ splitting versus not and if split if we should be interweaving the reads


Jonathan Keats Director of Bioinformatics & Assistant Professor Translational Genomics Research Institute

445 North Fifth Street, Phoenix, AZ, 85004 p: 602-343-8690 c: 480-543-0634 jkeats@tgen.org | www.keatslab.org | www.tgen.org

On Jul 28, 2017, at 14:56, denriquez notifications@github.com wrote:

Yes

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/tgen/pegasusPipe/issues/36#issuecomment-318721470, or mute the thread https://github.com/notifications/unsubscribe-auth/AL1RHKv0c6rb8oJYOB9kSZRg57HxJMpOks5sSiC_gaJpZM4OkaUQ.

--

This electronic message is intended to be for the use only of the named recipient, and may contain information that is confidential or privileged, including patient health information. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the contents of this message is strictly prohibited. If you have received this message in error or are not the named recipient, please notify us immediately by contacting the sender at the electronic mail address noted above, and delete and destroy all copies of this message. Thank you.