search

tgeorgeux / new.jupyter.github.io

This is the playground for the new Jupyter.org. Expecte great, or at least slightly better than mediocre, things.
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Add text #22

Closed marwahaha closed 5 years ago

marwahaha commented 5 years ago

image

compare to figma: https://www.figma.com/file/PQD2GrejGoeZdYGhXthnAuEs/jupyter_master?node-id=974%3A5059 image

fixes #14

cc @jameswenzel

I had to adjust the font-weight to get them to look similar to the spec.

tgeorgeux commented 5 years ago

@marwahaha Is the text in the image actually Helvetica Neue? Usually that font has a har flat line under the top portion of the 1 as is shown in the screenshot from Figma.

marwahaha commented 5 years ago

@tgeorgeux - good call out. I had reduced the font weight on the H1 and Subtitle 1 (and maybe others) because the font is much heavier than the one you have on Figma.

For example, here is H1 on my browser with font-weight: 400 image

tgeorgeux commented 5 years ago

Ah, for H1 did you set the font-weight to light?

On Thu, Sep 26, 2019 at 4:56 PM Kunal Marwaha notifications@github.com wrote:

@tgeorgeux https://github.com/tgeorgeux - good call out. I had reduced the font weight on the H1 and Subtitle 1 (and maybe others) because the font is much heavier than the one you have on Figma.

For example, here is H1 on my browser with font-weight: 400 [image: image] https://user-images.githubusercontent.com/2541209/65732372-839b3980-e07e-11e9-9f74-403627f8abc4.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tgeorgeux/new.jupyter.github.io/pull/22?email_source=notifications&email_token=AFIVZQCWMHTNYCBGBI7RZN3QLVD2LA5CNFSM4I2XHZQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7XI3QA#issuecomment-535727552, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIVZQERRDV2Q6DCLQIG5RLQLVD2LANCNFSM4I2XHZQA .

marwahaha commented 5 years ago

@tgeorgeux - the font-weight does not have a light option. Here are the options: https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight

lighter is an option, but I don't think that's what you mean.

On Figma, do the font-weights refer to this page? My font weights match your Figma specs using this mapping here. Light=300, which does not have the flat line under the 1. https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#Common_weight_name_mapping

marwahaha commented 5 years ago

@tgeorgeux - merging now. If there are problems we can revisit in a new PR.