Closed luxbe closed 6 months ago
Another possible improvement would be to turn NanoAddress into its own class with a constructor, that could check the input string for validity
The changes seems goods to me for now, you can continue on this path.
Good catch about the from
in the documentation, don't worry about this I will fix this in another PR, this is not the scope of this one.
Otherwise you TODO is appropriate for this feature.
I'm not sure about the NanoAddress
class, I think it will complicate the code and confused the user. Let keep it simple.
But if you have a strong argument for using it let me know.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
950505d
) to head (b7bd5c6
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should I also update the version to 1.3.0?
Should I also update the version to 1.3.0?
No don't worry, I will create a PR for this I think.
I'm not sure about the versioning protocol for now.
While reviewing, I saw that the change
method of the wallet is not in the documentation of the README, I will create an issue.
As groundwork to work on the Nano Name Service integration, I first introduced a basic
NanoAddress
type which represents valid Nano address in the form ofnano_.+
. I replaced the references to addresses fromstring
toNanoAddress
which affected more files than I initially expected.TODO:
ConfirmationFilter
includesfrom
, which does not exist in the actual interface.In the next step I plan to add a
NanoUsername
type to resolve actual usernames - however this is not part of this PR.Let me know what you think of the changes and also how I should proceed with the TODOs!
Closes #1