search

tgerring / hiveapp-bitstamptrader

Bitstamp trading application for Hive Wallet
MIT License
0 stars 5 forks source link

Last/High/Low does not respect mBTC/BTC setting #11

Open ghost opened 10 years ago

ghost commented 10 years ago

screen shot 2014-01-12 at 12 38 29 am

I guess if I have mBTC set, this should be show the amounts in mBTC, so as not to be confusing.

weilu commented 10 years ago

dibs!

weilu commented 10 years ago

Made the change for last/high/low and volume. Then I realized two things

  1. It is strange to see all the prices in $0.xx without having a unit(i.e. mBTC) somewhere on the page
  2. There are more numbers to fix if we want the unit setting to be global: e.g. balances, transfer, orders, transactions... And we probably want to make sure other apps do the same (how?)

Here are before and after(with both price tickers & balances respecting user setting) screenshots for comparison: screen shot 2014-01-20 at 2 10 35 pm screen shot 2014-01-20 at 2 09 52 pm

ghost commented 10 years ago

All displays of currency anywhere in Hive or any of its apps should respect the global denomination setting.

What's more, in the event that we should ever add a user toggle or switch to change it, all of them should update in realtime.

tgerring commented 10 years ago

@w-hive Do you have a suggestion on Karla's question 1 above?

ghost commented 10 years ago

We just discussed it. That unit should be mBTC along with all others in the app, if that is the app default. It is not necessary to display "mBTC" in that case, unless other units are also displayed around the page (dollars, etc). In this case, since they are, it might need to be displayed.

tgerring commented 10 years ago

Disagree about not showing the unit somewhere.

If the price of bitcoin is $1 with BTC preference and $1000 with mBTC preference, the app would be indistinguishable.

ghost commented 10 years ago

Indistinguishable from what?

tgerring commented 10 years ago

They would look identical without a unit listed.