search

tgfrerer / island

🌋🐎 Project Island is an experimental, hot-reloading Vulkan Renderer for Linux and Windows, written in C/C++.
MIT License
1.04k stars 42 forks source link

Support watching directories #24

Closed underdoeg closed 3 years ago

underdoeg commented 3 years ago

Sometimes you want to know what is going on in a directory. This is missing the windows implementation.

underdoeg commented 3 years ago

ah great I also included the cmake changes by accident...

underdoeg commented 3 years ago

I think I'll change this to an additional directory_watcher interface with more directory related settings

tgfrerer commented 3 years ago

i'm a bit confused about what this PR does... it seems it's the same changes as #23 ?

underdoeg commented 3 years ago

oh great... sorry, I have too many branches and changes locally. I've added my changes on top

tgfrerer commented 3 years ago

oh i see... would you mind making this a separate PR (without the module changes) so that we can look an test it in isolation?

that will also make it easier to add a windows implementation.

underdoeg commented 3 years ago

Will do, but I think, I'll approach it differently with a dedicated directory interface to avoid confusion

tgfrerer commented 3 years ago

Sounds good - shall we close this pr for now, then?

underdoeg commented 3 years ago

yes