search

tgherzog / wbgapi

Python module that makes using the World Bank's API a lot easier and more intuitive.
MIT License
140 stars 31 forks source link

Added SSL Cert Verification option #19

Closed mo-cmyk closed 2 years ago

mo-cmyk commented 2 years ago

Added the option to use a custom SSL Certificate when using proxies. This fix passes a custom verify option to the python requests default verify parameter. Otherwise, the package would have thrown an SSL Error when using proxies since the python requests module wasn't able to verify the SSL Certs and therefore authenticate the HTTPS Requests

@tgherzog Would be great if you could take a look at it.

mo-cmyk commented 2 years ago

Yes, but otherwise, proxy use is not possible, and the only way to use the API on a large scale would be a Monkey Patch enabling the feature you just denied, which seems like an unnecessary hustle. Why offer the proxy feature anyway, then?

tgherzog commented 2 years ago

Okay, you convinced me ;) but I implemented a more general approach which allows you to change all parameters to requests.get to allow more flexibility. Update to version 1.0.10 please.

mo-cmyk commented 2 years ago

Okay, you convinced me ;) but I implemented a more general approach which allows you to change all parameters to requests.get to allow more flexibility. Update to version 1.0.10 please.

Sounds like a good idea. Thanks!