search

tgingold-cern / cheby

GNU General Public License v3.0
7 stars 4 forks source link

Add golden files for interactive testing #17

Closed lorenzschmid closed 10 months ago

lorenzschmid commented 10 months ago

As stated earlier ./testfiles/tb/run.sh creates for each of its tests a set of VHDL files. Currently the repository contains the (outdated) VHDL of the last test. @tgingold argued that this serves as an additional verification upon PRs.

This PR adds now a set of golden files for all (!) tests independently of when they are run. In addition to this ./testfiles/tb/run.sh has been written in a more generic way and such as that it not only runs simulations (as before) but also compares actively the generated files with the previously generated ones (so called "golden files").

tgingold-cern commented 10 months ago

You have written what was missing !

lorenzschmid commented 10 months ago

Thanks for merging and you're welcome for the adaptations. I probably should have stated in my original message, that of course, I did nor verify the golden files compared to the original files. But considering that some old ones were outdated anyway, I think that it should be fine.