Add x-hdl attribute to control write mask generation

lorenzschmid commented 11 months ago

Originally introduced in d8c313276e086175e5a37b0ea0a8d0825b946bb1 (as part of #16), the hard-coded constant is replaced with a x-hdl attribute to be set on the memory map.

lorenzschmid commented 11 months ago

While this PR should simplify the use of the write mask feature (without changing the existing behavior), I have a few open questions:

Does this setting propagate to included submaps?
Without the hasattr(self.root, "hdl_wmask") check, the proto/tests.py tests would fail with the following error message: AttributeError: 'AddressSpace' object has no attribute 'hdl_wmask'. I always assumed that root relates to the memory map definition, no? Is this a problem or can I simply leave the hasattr effectively excluding all root instances not being a memory map?

lorenzschmid commented 11 months ago

If #26 is merged first, this PR has to be updated.

tgingold-cern / cheby

Add x-hdl attribute to control write mask generation #24