search

tgingold-cern / cheby

GNU General Public License v3.0
7 stars 4 forks source link

No port register type #26

Closed lorenzschmid closed 8 months ago

lorenzschmid commented 8 months ago

Add a new x-hdl.type no-port: Such register act like a small memory element having no input or output port.

lorenzschmid commented 8 months ago

If #24 is merged first, this PR has to be updated.

tgingold-cern commented 8 months ago

I am ok but can we use a name more explicit than virtual, something like no-io or no-port ?

At CERN, RF was using virtual in an old system to mean no register at all...

lorenzschmid commented 8 months ago

You are right, a virtual register is probably better describing a register, which does not actually exist in hardware.

How about closed, isolated, or unconnected register? Otherwise, I would also be fine with no-port. Let me know what you prefer.

tgingold-cern commented 8 months ago

I am not sure what closed or isolated refer to. Those registers are still connected to the bus, right ? (This also makes unconnected sound weird).

How about no-wire ?

(Sorry for not being enthusiastic with your names!)

lorenzschmid commented 8 months ago

No worries at all :) Of all proposals I like your original no-port best. Would that be fine with you?

tgingold-cern commented 8 months ago

yes, that's ok.

lorenzschmid commented 8 months ago

Thanks, I just updated this PR and the code to call it no-port.

tgingold-cern commented 8 months ago

Thanks!