Ext. Contribution

[iljabek]

Hello @tgingold-cern ,

we have found this project and are having a positive experience using it - thank you, first off.

I'm wondering what is the best procedure for contributions, since the main repo is hosted at CERN-GitLab and we don't have a developer with a CERN account.

• Do you have resources at all to deal with outside pull-requests, or are we better served with our own fork (we plan to maintain a mirror on-site as per institute preference)? We are not able to dedicate a lot of manpower, thus I don't expect groundbreaking changes.
• Is possible to communicate with the fork on GitHub or do we need to try for a CERN-GitLab account?
• There seem to be test-cases associated with each issue, is there any procedure for these to pass or are they or are they more illustrative?

Cheers, Ilja

[tgingold-cern]

Hello,

Nice to know you are using Cheby!

Yes, I do accept outside contributions from github. I manually synchronize both repos. So you can do merge request on github. For the issues, I think they are automatically run by the gitlab CI, but there is a test.py script which run them. That should be easy.

Cheers, Tristan.

---

From: Ilja Bekman @.> Sent: Thursday, March 21, 2024 10:46 AM To: tgingold-cern/cheby @.> Cc: Tristan Gingold @.>; Mention @.> Subject: [tgingold-cern/cheby] Ext. Contribution (Issue #38)

Hello @tgingold-cernhttps://github.com/tgingold-cern ,

we have found this project and are having a positive experience using it - thank you, first off.

I'm wondering what is the best procedure for contributions, since the main repo is hosted at CERN-GitLab and we don't have a developer with a CERN account.

• Do you have resources at all to deal with outside pull-requests, or are we better served with our own fork (we plan to maintain a mirror on-site as per institute preference)? We are not able to dedicate a lot of manpower, thus I don't expect groundbreaking changes.
• Is possible to communicate with the fork on GitHub or do we need to try for a CERN-GitLab account?
• There seem to be test-cases associated with each issue, is there any procedure for these to pass or are they or are they more illustrative?

Cheers, Ilja

— Reply to this email directly, view it on GitHubhttps://github.com/tgingold-cern/cheby/issues/38, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL3BNY7ATOEQRNJKNICUAWLYZKUARAVCNFSM6AAAAABFBC3PZWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TSNRXGQYDINQ. You are receiving this because you were mentioned.Message ID: @.***>

[iljabek]

I'm having trouble running the test_interaction job, can you recommend a docker image or GHDL version it is meant to be run with? i'm noticing that on CERN CI only _generate job is executed for testing. Is NO_GHDL="Y" the default?

[tgingold-cern]

For the docker image, you can use https://hub.docker.com/r/ghdl/ghdl Yes, at cern NO_GHDL is set to Y

---

From: Ilja Bekman @.> Sent: Monday, March 25, 2024 11:51 AM To: tgingold-cern/cheby @.> Cc: Tristan Gingold @.>; Mention @.> Subject: Re: [tgingold-cern/cheby] Ext. Contribution (Issue #38)

I'm having trouble running the test_interaction job, can you recommend a docker image or GHDL version it is meant to be run with? i'm noticing that on CERN CI only _generate job is executed for testing. Is NO_GHDL="Y" the default?

— Reply to this email directly, view it on GitHubhttps://github.com/tgingold-cern/cheby/issues/38#issuecomment-2017718286, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL3BNY426LPLR65AFYMDPEDYZ76SXAVCNFSM6AAAAABFBC3PZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXG4YTQMRYGY. You are receiving this because you were mentioned.Message ID: @.***>

[iljabek]

questions have been answered

[stefanlippuner]

Hey @iljabek, nice to see that you're using Cheby :)

Just a few small comments from my side:

• The tests should run on Github if you open a PR (both generation and interaction): e.g. https://github.com/tgingold-cern/cheby/actions/runs/8449713713 The action is defined here: https://github.com/tgingold-cern/cheby/blob/master/.github/workflows/ci.yml.
• The tests should be able to run with most GHDL versions (verilator is much more problematic), as the VHDL code desn't use any fancy language features. In the Github CI, it's run using the GHDL 1.0 (default for Ubuntu 22.04). Locally, I'm running them using GHDL 3.0 (I suppose I should update to GHDL 4.0 :) ).

[iljabek]

Hey @iljabek, nice to see that you're using Cheby :)

Just a few small comments from my side:

* The tests should run on Github if you open a PR (both generation and interaction): e.g. https://github.com/tgingold-cern/cheby/actions/runs/8449713713 The action is defined here: https://github.com/tgingold-cern/cheby/blob/master/.github/workflows/ci.yml.

* The tests should be able to run with most GHDL versions (verilator is much more problematic), as the VHDL code desn't use any fancy language features. In the Github CI, it's run using the GHDL 1.0 (default for Ubuntu 22.04). Locally, I'm running them using GHDL 3.0 (I suppose I should update to GHDL 4.0 :) ).

we were able to setup Gitlab CICD on our side (which required a bit of pipeline tuning), as well as running the tests locally.