tgjones / HlslTools

A Visual Studio extension that provides enhanced support for editing High Level Shading Language (HLSL) files
http://timjones.io/blog/archive/2016/04/25/hlsl-tools-for-visual-studio-v1.0-released
Other
568 stars 98 forks source link

Autocomplete doubles up first letter #111

Closed Friendly0Fire closed 5 years ago

Friendly0Fire commented 7 years ago

Steps to reproduce:

  1. With Intellisense on, type a variable or function name.
  2. When autocomplete shows up, select any of the suggestions.
  3. The first letter will be doubled up, e.g. CalcSceneColorAndDepth becomes CCalcSceneColorAndDepth.
AdamJMiles commented 7 years ago

I can confirm I'm affected by this too.

PathogenDavid commented 7 years ago

I can also confirm this is happening with Visual Studio 2017.

Specifically, it seems that this happens with symbols that start with an uppercase letter, and only if you start by typing that first letter as uppercase. (For example, if the actual symbol is InputChunk and you type inp it is fine, but if you type Inp it breaks.)

I've narrowed down that this issue was introduced in 1.1.266, which includes the following commits:

Since the latter commit is only related to the tests, I'm inclined to believe the former is the culprit.

Those wishing to get the last version of the extension before the issue was introduced can find it on AppVeyor: https://ci.appveyor.com/project/tgjones/hlsltools/build/1.1.265/artifacts

Friendly0Fire commented 7 years ago

Hmm, I don't know if the install failed but I tried using that version and I still get the bug.

PathogenDavid commented 7 years ago

You might need to uninstall the gallery version and disable automatic extension updates. (You will start receiving manual update notifications instead.) You should also double-check the version number that Visual Studio thinks is installed under Tools > Extensions and Updates.

Lex-DRL commented 7 years ago

I confirm the same issue in VS Community 2015 Update 3, in Unity-style shader (ShaderLab wrapping around HLSL), with the latest ext version (1.1.272).

Flave229 commented 6 years ago

I can confirm this is also broken on VS Enterprise 2017 version 15.4.2 Using HLSL tool version 1.1.272

Any fix inbound to address this?

BenjaminHolland commented 6 years ago

Also can confirm, Ext. Version 1.1.272 VS Version 15.4.5

dkudrin commented 5 years ago

This bug is still there. UE4 .usf files

tgjones commented 5 years ago

Fixed by https://github.com/tgjones/HlslTools/commit/461385b349d909a661e210077fe1b6435d3575f5#diff-7eca9edd2fd844942ba8634f4eb885ba.