[Includes] Some improvements

[mrvux]

Hello, as mentioned in #130 , here are some improvements for include system :

The main rationale about it is to also allow some finer control when using core libraries in custom tooling.

• Added Include type enumeration

• IncludeDirectiveTriviaSyntax gets a boolean "IsLocal"

• Pass Include type to both Include Resolver and File System (depending on local flag)

• Current file systems and resolver are ignoring flag (so this will not be a breaking change)

• Allow to pass our own IIncludeFileResolver to ParseSyntaxTree .

• To be allowed to use our own IIncludeFileResolver, we need to provide a source file, so constructor is now public.

• I added small tests to verify that syntax flags are correct, and that custom resolver gets called properly.

One discussion part I would have, is that passing IIncludeFileResolver is required, since our include system might not be not file based (zip/resource/memory...) so default resolver will never find the file, and never call the filesystem.

So maybe we should even remove IIncludeFileSystem from the argument list (since resolver should provide it's own file system anyway, or never provide one) ?

Thanks

[tgjones]

So maybe we should even remove IIncludeFileSystem from the argument list (since resolver should provide it's own file system anyway, or never provide one) ?

I agree - let's remove IIncludeFileSystem from the argument list.

[Krakean]

@tgjones @mrvux this hasn't been merged into master yet?

[mrvux]

This did not, issue is there been a large change in between and this will conflict merge. Theres an issue with new version that it cant build with visual studio as well, wanted to fix that but had a bit little time.