search

tgjones / HlslTools

A Visual Studio extension that provides enhanced support for editing High Level Shading Language (HLSL) files
http://timjones.io/blog/archive/2016/04/25/hlsl-tools-for-visual-studio-v1.0-released
Other
561 stars 97 forks source link

Editorconfig support #173

Closed Reedbeta closed 4 years ago

Reedbeta commented 4 years ago

This uses Visual Studio's built-in functionality for finding and parsing the .editorconfig file, by hooking up VS's IEditorOptions interface to HLSL Tools' OptionService. It mainly affects smart indent width, as tabs/spaces and newlines were apparently already working correctly through other means (I'm not sure exactly how).

This is dependent on my previous pull request #171 (and won't work properly without it).

tgjones commented 4 years ago

Now that I've merged #171, do you mind rebasing on latest master so I can see the actual diff for this one please?

Reedbeta commented 4 years ago

Done! Thanks.

tgjones commented 4 years ago

Thank you! I didn't know there was an API to get at editorconfig options like this. That's cool. At some point I'd also like to support it in the VSCode extension, but we can cross that bridge later.