macro VariadicArgument - Githubissues

tgjones / HlslTools

A Visual Studio extension that provides enhanced support for editing High Level Shading Language (HLSL) files

Other

565 stars 97 forks source link

Closed Jasonchan35 closed 1 month ago

Jasonchan35 commented 2 years ago

Added support for macro variadic argument not perfect though, but it works well and maybe should add some unit test case in the future

tgjones commented 2 years ago

Hi @Jasonchan35 - thanks for this! I tried to write a test for this but I don't think the implementation actually works:

token.Kind is never equal to SyntaxKind.VariadicArgumentKeyword. Instead it's token.ContextualKind that it should be checking for.
The code that inserts the variadic arguments into the argument list doesn't insert comma tokens but it should.

I'd love to accept this PR but please could you add at least one test to validate that it works?