search

tgjones / HlslTools

A Visual Studio extension that provides enhanced support for editing High Level Shading Language (HLSL) files
http://timjones.io/blog/archive/2016/04/25/hlsl-tools-for-visual-studio-v1.0-released
Other
553 stars 95 forks source link

Pragma once is ignored #247

Open Nielsbishere opened 1 year ago

Nielsbishere commented 1 year ago

pragma once should allow duplicate includes to be ignored. Currently it'll think the same symbols are defined multiple times if one of the includes includes the same include as a different include. The error is about ambiguous symbols.

BenSimsTantalus commented 1 year ago

This would be great, especially because Unreal's shaders use #pragma once everywhere, and HLSL tools is now included in the latest Visual Studio previews along with improved Unreal support. I think this also causes a lot of slowdowns as it means the same files are processed many times.

tgjones commented 11 months ago

I agree, this would be a nice feature to add. PRs gratefully accepted 😄