search

tgjones / HlslTools

A Visual Studio extension that provides enhanced support for editing High Level Shading Language (HLSL) files
http://timjones.io/blog/archive/2016/04/25/hlsl-tools-for-visual-studio-v1.0-released
Other
568 stars 98 forks source link

Make SourceFieldSymbol public? #28

Closed amerkoleci closed 8 years ago

amerkoleci commented 8 years ago

Hi, I'm using SourceFieldSymbol to access Syntax property (VariableDeclaratorSyntax), would be possible to make it public, no need public constructor.

Thank you

tgjones commented 8 years ago

Yes, no problem. I don't see why those Symbol subclasses shouldn't be public.

Do you need access to IntrinsicTypes? I was considering making it internal.

amerkoleci commented 8 years ago

No I dont have, please update System.Collection.Immutable nuget package to latest 1.1.37.0 too

amerkoleci commented 8 years ago

Note also that HlslTools.csproj has "System.Runtime" path pointing too "..............\Program Files (x86)\Reference Assemblies\Microsoft\Framework.NETCore\v4.5\System.Runtime.dll"

tgjones commented 8 years ago

I've made all the Symbol classes public, with internal constructors. I've upgraded System.Collections.Immutable to 1.1.37, and removed the errant reference to System.Runtime.dll.

amerkoleci commented 8 years ago

Thank you