tgockel / json-voorhees

A killer modern C++ library for interacting with JSON.
http://tgockel.github.io/json-voorhees/
Apache License 2.0
128 stars 18 forks source link

adding boost::optional support #70

Closed venediktov closed 8 years ago

venediktov commented 8 years ago

Hi Travis , I have started using your jsonv library in my new project https://github.com/venediktov/vanilla-rtb My repo is referencing your project via 'git subtree'

my structures are rather complex but also require boost::optional which are not supported out of the box in your library, therefore I decided to make a pull request , please see incoming changes

in future I might be using http://en.cppreference.com/w/cpp/experimental/optional if I move it to C++17 instead of boost::optional ...

I hope DSL from your package will work for my exchange_handlers like in my proof of concept use cases below. The idea is instead of marshalling manually I would have DSL files /classes that will do conversion from custom json formats into one class called openrtb::BidRequest , openrtb::BidResponse

https://github.com/venediktov/cplusplus/blob/master/serialization_builder_tests.cpp https://github.com/venediktov/cplusplus/blob/master/openrtb.hpp

If you are interested to contribute to my project I would be delighted !

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.621% when pulling 39ff992bab2cc4cee1a2a89105ab91d991a830aa on venediktov:master into 41df572f8f95dc94a777e566839a306359c16b6d on tgockel:master.

venediktov commented 8 years ago

Travis , I am not familiar with this incremental build system , looking at the errors does not seem related to my pull request changes ?

W: Failed to fetch http://llvm.org/apt/precise/dists/llvm-toolchain-precise/main/binary-amd64/Packages 404 Not Found W: Failed to fetch http://llvm.org/apt/precise/dists/llvm-toolchain-precise/main/binary-i386/Packages 404 Not Found E: Some index files failed to download. They have been ignored, or old ones used instead. The command "sudo apt-get update" failed and exited with 100 during .

tgockel commented 8 years ago

Unfortunately, LLVM's Debian repo is less than reliable. So yes, not your fault (and super annoying for all parties involved).

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.621% when pulling 16ec6e5b8c13cd39d7f9e2e8edaf2f5152811aa2 on venediktov:master into 41df572f8f95dc94a777e566839a306359c16b6d on tgockel:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.621% when pulling 83fe5c5e1c0bbdb24445dfda4439c358cab0b461 on venediktov:master into 41df572f8f95dc94a777e566839a306359c16b6d on tgockel:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.621% when pulling 76ea01afbdeb57b347bea1374df9cbdfbd848bb1 on venediktov:master into 481c230a3aa3885bf721f0874030e69f1aba35e6 on tgockel:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.621% when pulling 9b6de9a9eb24702c445dcbe2eb77410d327b7add on venediktov:master into 481c230a3aa3885bf721f0874030e69f1aba35e6 on tgockel:master.

venediktov commented 8 years ago

OK, will merge from your master and apply your comments...

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.629% when pulling 2532e0fce36af8afabad0f9b5318ef8745fd97d3 on venediktov:master into ef07a6543c03659594d5a18bcddcdf590366b938 on tgockel:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.629% when pulling 41ff6ac729bec134e158a66e901501ebbfeead8f on venediktov:master into ef07a6543c03659594d5a18bcddcdf590366b938 on tgockel:master.

venediktov commented 8 years ago

VS 2014 e.g vc14.0 does not support std::experimental::optional , I will fix jsonv/optional.hpp

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.629% when pulling 750cfcc1b093230dbd815e22abdfb4baa0637181 on venediktov:master into ef07a6543c03659594d5a18bcddcdf590366b938 on tgockel:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.06%) to 95.629% when pulling 355897faa2816fa7177775d3d8b11dbfc9212940 on venediktov:master into ef07a6543c03659594d5a18bcddcdf590366b938 on tgockel:master.