Closed venediktov closed 8 years ago
Travis , I am not familiar with this incremental build system , looking at the errors does not seem related to my pull request changes ?
W: Failed to fetch http://llvm.org/apt/precise/dists/llvm-toolchain-precise/main/binary-amd64/Packages 404 Not Found W: Failed to fetch http://llvm.org/apt/precise/dists/llvm-toolchain-precise/main/binary-i386/Packages 404 Not Found E: Some index files failed to download. They have been ignored, or old ones used instead. The command "sudo apt-get update" failed and exited with 100 during .
Unfortunately, LLVM's Debian repo is less than reliable. So yes, not your fault (and super annoying for all parties involved).
OK, will merge from your master and apply your comments...
VS 2014 e.g vc14.0 does not support std::experimental::optional , I will fix jsonv/optional.hpp
Hi Travis , I have started using your jsonv library in my new project https://github.com/venediktov/vanilla-rtb My repo is referencing your project via 'git subtree'
my structures are rather complex but also require boost::optional which are not supported out of the box in your library, therefore I decided to make a pull request , please see incoming changes
in future I might be using http://en.cppreference.com/w/cpp/experimental/optional if I move it to C++17 instead of boost::optional ...
I hope DSL from your package will work for my exchange_handlers like in my proof of concept use cases below. The idea is instead of marshalling manually I would have DSL files /classes that will do conversion from custom json formats into one class called openrtb::BidRequest , openrtb::BidResponse
https://github.com/venediktov/cplusplus/blob/master/serialization_builder_tests.cpp https://github.com/venediktov/cplusplus/blob/master/openrtb.hpp
If you are interested to contribute to my project I would be delighted !