search

tgoodyear / dpkt

Automatically exported from code.google.com/p/dpkt
Other
0 stars 0 forks source link

dpkt 1.8 does not build with python 2.4 #116

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. run "python2.4 setup.py build"

What is the expected output? What do you see instead?
Expected successful build but got:

Traceback (most recent call last):
  File "setup.py", line 4, in ?
    import dpkt
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-dpkt/py24-dpkt/work/dpkt-1.8/dpkt/__init__.py", line 62, in ?
    import ssl
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-dpkt/py24-dpkt/work/dpkt-1.8/dpkt/ssl.py", line 149
    padding = '\x00' if lenbytes == 3 else ''
                      ^
SyntaxError: invalid syntax

What version of the product are you using? On what operating system?
dpkt 1.8 on OS X 10.8.5

Please provide any additional information below.
dpkt 1.7 built fine with Python 2.4 and the CHANGES file does not mention any 
change in requirements for version 1.8. So this is either a request to fix 
compatibility with python 2.4 or document that python 2.5 is now required.

Original issue reported on code.google.com by ryandesi...@gmail.com on 22 Oct 2013 at 8:35

GoogleCodeExporter commented 9 years ago 
This was introduced in ssl.py (in r83, older was r46). This is PEP 308 style 
code and now requires python2.5 or later to work. 
I propose we fix this to make it work with python2.4

Original comment by kbandla@in2void.com on 29 Dec 2014 at 8:45