search

tgoossens / htttp-peno

Het Team Treasure Trek Protocol (HTTTP) protocol over rabbitmq for P&O4 2013
5 stars 3 forks source link

Handler also handles changes to ready states for players. #14

Closed ericdepotter closed 11 years ago

ericdepotter commented 11 years ago

Is it possible to let the handler also have a method that is called when a player in the game changes its ready status?

MattiasBuelens commented 11 years ago

I see you had already forked and implemented a fix for this on your own in 8434b3ed1abb2376861a2ca18fe48cade28948be. I based my fix on your code and reworked it a little to fit in the updated Client.

Next time, I suggest you make a pull request to pull your fixes into our master branch. You can make a few commits in your own separate branch, request to pull them into our master branch, discuss your changes and make some follow-up commits and finally I can merge the result into the master branch. After all, that's what GitHub means with social coding. :wink: