search

tgriesser / checkit

simple, flexible validations for node and the browser
MIT License
223 stars 53 forks source link

Use the specific lodash methods we care about #65

Closed Whoaa512 closed 8 years ago

Whoaa512 commented 8 years ago

Reduces the browser build by about 275kb and the minified by 20kb Should also be faster to require for node side of things

rhys-vdw commented 8 years ago

Nice one. Could you add a comment to the top of lodash-requires explaining that this is to reduce build size/memory consumption? This might not be obvious to some.

Whoaa512 commented 8 years ago

Sure.

Question, should I include the changes to the build files in my PR as well?

rhys-vdw commented 8 years ago

@Whoaa512 tbh they should be removed from version control. You could add them to .gitignore as part of #69 if you like.