Parser lacks Unicode support

tgrosinger / ledger-obsidian

Plain text accounting in Obsidian.md

GNU General Public License v3.0

388 stars 38 forks source link

Parser lacks Unicode support #5

Closed tgrosinger closed 3 years ago

tgrosinger commented 3 years ago

As reported by @BigbadHort in this issue, the parser does not currently support non-ascii characters.

Additionally the Р symbol (which I think is not actually uppercase p) needs to be added as a currency symbol.

tgrosinger commented 3 years ago

I have added unicode support, however there are other features used in the file you provided in the other issue which are not supported yet:

You'll need to provide the full date, as the Y2021 syntax is not yet supported
There should always be a blank line between transactions

Let me know how it goes! Please open a new issue if you find more bugs.

BigbadHort commented 3 years ago

i corrected the transaction log to full date format there is always an empty line between transactions

at the moment I can add transactions, but I cannot get a hint when choosing an account (as it was possible when there were only ascii characters in the file)

this is the error that appears after the click

leg6

its my file ledger.md

tgrosinger commented 3 years ago

I'm still investigating, but I did find a couple more things:

The reconcile symbols must be on an expense line, not on the first line of the transaction. For example:
```
2019/09/01 Tacos
  e:Food:Restaurant                            $21.00
* c:Credit
```
The currency symbol you are using should be Р (U+0420). Using P or p will not work. I am not familiar with this currency though, so please do let me know if that's incorrect or if another character should be allowed.

But there is still another bug that I am investigating though which is causing problems.

tgrosinger commented 3 years ago

I released 0.0.8 with a fix. Please upgrade and give it a go, using the additional changes from the previous comment. Let me know how it goes. Thanks for your help and patience!

BigbadHort commented 3 years ago

Hooray!! now everything works! :-) What I've done:

updated to 0.0.8
replaced the currency symbol (via the buffer from your message)
Thanks for the work you've done!!

regarding the currency symbol, here is the complete information: https://en.wikipedia.org/wiki/Ruble_sign

p.s. I want to advertise your plugin in the obsidian channel. Do you mind?

BigbadHort commented 3 years ago

Do you plan to output information in the form of graphs-tables or limit yourself only to input?

tgrosinger commented 3 years ago

I want to advertise your plugin in the obsidian channel. Do you mind?

Not at all. Thank you 🙂

Do you plan to output information in the form of graphs-tables or limit yourself only to input?

I do have plans to add output information. I think first I am going to add an interactive reconciliation though. I have however gotten a little distracted working on another task management plugin. I'll be back though and will add these features eventually!