search

tgrosinger / ledger-obsidian

Plain text accounting in Obsidian.md
GNU General Public License v3.0
388 stars 38 forks source link

Correctly parse reconciled transactions #53

Open AB1908 opened 1 year ago

AB1908 commented 1 year ago

Fixes #9 partially. I'm still unsure about how to use this in parser.ts and would appreciate some guidance.

My tests also might not be the best, would appreciate suggestions.

tgrosinger commented 1 year ago

This looks great. It looks like you have been able to update it so that the value is parsed, but is not actually being used in the application. That should be sufficient for at least making files with this reconciliation flag parsable.

It looks like there are some failures in the tests, but I am not sure if they are introduced by this change or not. It's been a very long time since I have worked in this project.

AB1908 commented 1 year ago

Oh, you're right, I never ran the full test suite. Let me check that out. If they turn out to be unrelated, I'll push those in a separate PR and rebase this on top of that (or at least that how I think it's done).