search

tgrosinger / ledger-obsidian

Plain text accounting in Obsidian.md
GNU General Public License v3.0
414 stars 41 forks source link

Support for comments and cleared flag * #9

Open michaelede opened 2 years ago

michaelede commented 2 years ago

Would it be possible to incorporate an optional comment box, and also the ability to asterisk journals that have already cleared to the bank?

tgrosinger commented 2 years ago

Yes, both are planned in the long run.

tgrosinger commented 2 years ago

Comments are added in 0.3.0. Reconciliation flags are parsed and preserved, but are not visible in the UI yet.

Signynt commented 2 years ago

Comments are added in 0.3.0. Reconciliation flags are parsed and preserved, but are not visible in the UI yet.

Will there be a way to quickly view the comments? Currently the only way I've found is to edit the transaction. Perhaps the comment could be displayed on hover over the transaction?

tgrosinger commented 2 years ago

I don't yet have a plan for how to display them. I may make the table rows expandable to display them. But I'm open to other suggestions as well. Editing the transaction is also the only way to view the transaction splits right now.

AB1908 commented 1 year ago

Are reconciliation flags parsing? I get a parsing error. Using the example from ledger-cli docs: image

AB1908 commented 1 year ago

Ah this is much more difficult to debug than I thought. It seems that after consuming a reconciled token, the nextColumn gets populated incorrectly. @tgrosinger, I'm happy to fix this but could you give me any ideas? It seems moo comes with a steep learning curve, especially since I've forgotten much about compilers.

AB1908 commented 1 year ago

I think this is the line: https://github.com/tgrosinger/ledger-obsidian/blob/66738712aede898529f36652c7e04c937b3d91b3/grammar/ledger.ne#L69.

Once we modify this, it would also need some logic in parser.ts