search

tgrosinger / tw5-checklist

Simple checklist widget for TiddlyWiki5:
https://tgrosinger.github.io/tw5-checklist/
51 stars 12 forks source link

Accessibility and Usability Optimisations #31

Closed telmiger closed 7 years ago

telmiger commented 7 years ago

As discussed with Josiah … https://github.com/tgrosinger/tw5-checklist/issues/29#issuecomment-304064258

The demo is updated here: https://tid.li/tw5/test/checklist.html

A big step for this wonderful plugin :)

tgrosinger commented 7 years ago

@telmiger Can you put up a an updated version of your demo when you get a chance? Thank you again!

telmiger commented 7 years ago

The new version, in which I have tried to consider all your inputs, is online: https://tid.li/tw5/test/checklist.html – I hope you like it. If I find out how to update a PR, I will be happy to do so.

tgrosinger commented 7 years ago

@telmiger the new demo looks awesome! Once you push the changes to the pull request I will take a final pass over it and then we can get it merged.

Please notice that I made a small change in the Usage.tid which has caused a merge conflict in your review.

tgrosinger commented 7 years ago

@telmiger I just checked out your branch to build the state that has been uploaded, but it is definitely missing changes that are reflected in the demo you uploaded. You should be able to just use a git push to upload a new version of your changes.

telmiger commented 7 years ago

My master branch is updated. Should I send a new PR or can you proceed with this one here?

tgrosinger commented 7 years ago

No need for a new PR, I can see the commits and will take a look at them as soon as I get a chance. Thank you!