search

tgrospic / rnode-client-js

Web example https://tgrospic.github.io/rnode-client-js
MIT License
19 stars 19 forks source link

avoid automatic semicolon insertion (ASI) hazard? #16

Open dckc opened 4 years ago

dckc commented 4 years ago

One of the hazards Agoric left out of Jessie is automatic semicolon insertion.

I'd appreciate it if we could avoid that hazard in this repo; my editors make lots of noise on every line with a missing semicolon at the end.

I tend to follow their style; it's based on airbnb style; the details are in https://github.com/Agoric/new-repo .

tgrospic commented 4 years ago

I don't think semicolon is problematic as before. With the use of linters and preprocessors for JS the danger part is eliminated. https://standardjs.com/rules.html#semicolons

I follow JavaScript Standard Style which has support for VSCode and also other editors. https://standardjs.com/#are-there-text-editor-plugins

dckc commented 4 years ago

OK, using Standard Style does seem to address the ASI hazard.

I thought about closing this now, but I prefer to leave it open until a CI check enforces this style on master.

If you prefer to close this now, I don't mind if you go ahead.