search

tgsmith61591 / pytolemy

1 stars 0 forks source link

Adding Gdal to requirements #5

Open gigly222 opened 6 years ago

gigly222 commented 6 years ago

Adding Gdal to requirements.

I am thinking to convert a jp2 file to tiff, we might want to use gdal for this task. https://gis.stackexchange.com/questions/214489/handle-jp2-sentinel-data/214492

tgsmith61591 commented 6 years ago

If Gdal requires a C build, we probably don't want it in the requirements. What we can do is make it a "develop" requirement (you need it pre-installed to run the tests or build with python setup.py develop), but will be pre-built for the binary dist when we get to that stage. It's the same way scikit handles Numpy or Cython if you want to build it.

gigly222 commented 6 years ago

I found some gdal binaries for Mac: http://www.kyngchaos.com/software/frameworks/

tgsmith61591 commented 6 years ago

It looks like we can just install it from Pypi? Why not do that? Then CI envs would just need libgdal and Numpy to build. Then when we build a bdist for pypi, it will be bundled in.

tgsmith61591 commented 6 years ago

Let's throw GDAL into requirements.txt and we can monkey-patch some of the setup logic into the setup.py.

gigly222 commented 6 years ago

monkey patch?

On Tue, Sep 18, 2018 at 2:21 PM Taylor G Smith notifications@github.com wrote:

Let's throw GDAL into requirements.txt and we can monkey-patch some of the setup logic into the setup.py.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tgsmith61591/pytolemy/issues/5#issuecomment-422516337, or mute the thread https://github.com/notifications/unsubscribe-auth/AJUuvo777POjVtRdnQQotZxrx3DWh2oRks5ucUe6gaJpZM4WscYU .