Closed tgsmith61591 closed 6 years ago
Merging #6 into image_format_conversion will increase coverage by
0.45%
. The diff coverage is97.05%
.
@@ Coverage Diff @@
## image_format_conversion #6 +/- ##
===========================================================
+ Coverage 97.72% 98.18% +0.45%
===========================================================
Files 8 15 +7
Lines 88 165 +77
===========================================================
+ Hits 86 162 +76
- Misses 2 3 +1
Impacted Files | Coverage Ξ | |
---|---|---|
pytolemy/utils/distance.py | 100% <ΓΈ> (ΓΈ) |
:arrow_up: |
pytolemy/utils/__init__.py | 100% <ΓΈ> (ΓΈ) |
:arrow_up: |
pytolemy/image/tests/test_format.py | 100% <100%> (ΓΈ) |
|
pytolemy/utils/tests/test_testing.py | 100% <100%> (ΓΈ) |
|
pytolemy/image/tests/__init__.py | 100% <100%> (ΓΈ) |
|
pytolemy/datasets/tests/test_caching.py | 100% <100%> (ΓΈ) |
|
pytolemy/image/__init__.py | 100% <100%> (ΓΈ) |
|
pytolemy/utils/testing.py | 100% <100%> (ΓΈ) |
|
pytolemy/datasets/tests/__init__.py | 100% <100%> (ΓΈ) |
|
pytolemy/image/format.py | 100% <100%> (ΓΈ) |
|
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 865cc69...b4d6b35. Read the comment docs.
I made several changes to the package that you will probably want in your branch. Notable changes:
I've kept your tests and moved them over to the "
image/tests
" directory, with some minor amendments. You can go from here...The test dataset we were using didn't have a TIFF file in it. Now it does, so the zip repo is significantly larger. Let's avoid at all costs updating this any further or our git history will grow quite large (TIFFs evidently cannot compress very well at all).
A couple new testing utils in
pytolemy.utils.testing
that will make your life easier:get_test_image_dir
get_test_image_files
The conversion code is still yours to write, just making the organization and testing a little more intuitive because sleep eludes me π€ βοΈ