search

tgsoverly / smart-things

Custom device type handlers for the SmartThings platform
MIT License
3 stars 2 forks source link

Max button should set value of fan to 7 #2

Open tgsoverly opened 7 years ago

jterrace commented 6 years ago

Why is 7 used as the max? Mine goes up to 10

tgsoverly commented 6 years ago

The version I built this off of went to 7. 🤷‍♂️

jterrace commented 6 years ago

Interesting. What model number and software version do you have? Mine is 3200 WHF and software version 2.15.1.

tgsoverly commented 6 years ago

I actually don't own one, I did this off a friends one. Do you have the fan with the new controller with all the blue lights?

On Fri, Jul 20, 2018 at 10:47 PM Jeff Terrace notifications@github.com wrote:

Interesting. What model number and software version do you have? Mine is 3200 WHF and software version 2.15.1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tgsoverly/smart-things/issues/2#issuecomment-406765496, or mute the thread https://github.com/notifications/unsubscribe-auth/AAddDGPThePNSKwjhxf6o0qoqGk_2XLaks5uIpZBgaJpZM4LxeiR .

jterrace commented 6 years ago

No, I bought the older generation 2 controller instead of using the new capacitive fancy one (from here https://blog.airscapefans.com/archives/new-controls). You can actually see on that page in the last paragraph, they say it's not compatible at all with the remote control or API. I'm not sure why they went with a capacitive switch anyway, since capacitive switches are awful for usability.

I can make the max value a parameter so people can pick. Unfortunately, I don't see "10" anywhere in the API responses to be able to set it programmatically. Though it's possible it might depend on the software version, which is available.

Anyway, I have a lot of improvements I could send you, but I'm not allowed to contribute to an open source project without a license by policy of where I work. So if you add a license, I'll send you my changes.

tgsoverly commented 6 years ago

As I remember (from two years ago) the commands were only up and down so you would have to step up the correct number. I have added a license if you want to throw up a PR.

On Sat, Jul 21, 2018 at 12:20 PM Jeff Terrace notifications@github.com wrote:

No, I bought the older generation 2 controller instead of using the new capacitive fancy one (from here https://blog.airscapefans.com/archives/new-controls). You can actually see on that page in the last paragraph, they say it's not compatible at all with the remote control or API. I'm not sure why they went with a capacitive switch anyway, since capacitive switches are awful for usability.

I can make the max value a parameter so people can pick. Unfortunately, I don't see "10" anywhere in the API responses to be able to set it programmatically. Though it's possible it might depend on the software version, which is available.

Anyway, I have a lot of improvements I could send you, but I'm not allowed to contribute to an open source project without a license by policy of where I work. So if you add a license, I'll send you my changes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tgsoverly/smart-things/issues/2#issuecomment-406807505, or mute the thread https://github.com/notifications/unsubscribe-auth/AAddDB4dAP1uUZ3d6m2oVzEmcZ3h2SVrks5uI1TogaJpZM4LxeiR .