tgstation / MapDiffBot

Tool for generating diff images of BYOND maps
GNU Affero General Public License v3.0
8 stars 11 forks source link

map renderings do not account for pixelshifted objects #102

Open Amelia0010 opened 5 years ago

Amelia0010 commented 5 years ago

[17:32] Nich: @SpaceManiac If an object has pixel_y/x set to be outside of the tile, mapdiffbot's rendering doesn't expand the image appropriately. As an example, someone on yogs added a second red-alert-thingy to the bridge, both being on the wall to the AI upload, but they're outside of the rendering's range [17:32] Nich: image

[17:32] Nich: with my crudely drawn red dots being where they are now [17:32] Nich: https://github.com/yogstation13/Yogstation-TG/pull/4702/checks?check_run_id=73845208 [19:14] SpaceManiac: I'd have to negotiate w/ Cyberboss about this. My tools report the changed tiles w/o pixel_xy data and MDB calculates the rectangle surrounding them and passes that as the bounding box of the render [21:39] Nich: yeah I wasn't sure whether this'd be an issue for you or him [14:59] Cyberboss: its an issue for me, i guess i can just inflate the radius mdb renders by 1? [14:59] Cyberboss: either way open an issue on the repo or ill forget