tgstation / TerraGov-Marine-Corps

TGMC: TerraGov Marine Corps, a SS13 mod
GNU Affero General Public License v3.0
162 stars 814 forks source link

Hold to sprint/stalk key isn't working correctly. #13930

Open Wisemonster opened 1 year ago

Wisemonster commented 1 year ago

Description

Hold to sprint/stalk is supposed to make it so holding causes you to sprint/stalk, but releasing it stops sprinting/stalking, however as of recently it has been a 1-way toggle for sprinting/stalking, not stopping sprinting/stalking after releasing it, and not toggling sprinting/stalking if it is already active. As an addition, I have examine bound to shift as well as Hold to sprint/stalk.

Test Merges

Server-Side Code Modifications: https://tgstation13.org/parsed-logs/sybil/server_side_modifications.dm

Round ID: 23123 BYOND Version: 515.1610 Server revision compiled on: 2023-09-05T11:58:01+00:00 Master commit: e4f05103a035ed1c38356136b6245eb029b2514c The following pull requests are currently test merged: #13543: 'Personal statistics' by XElectricX at commit dfeee12246 #13910: 'New Warcries: TGMC Edition' by XSlayer300 at commit 6cba28d8a0 #13914: 'TGS Arachne' by AzonStarfall at commit f0707f0e68 #13615: 'Maturity Removal (Part of the Xeno Rework)' by Barnet2 at commit b8e78e95d9 #13925: 'Adds a xeno respawn timer' by Barnet2 at commit e6305ba401

Local commit: 65229ce73c0aa2c5bfccd9ec76fb21582fc188ca Server tools version: 5.15.1

Reproduction Steps

  1. Be a xeno
  2. Bind Shift key to "hold to Sprint/Stalk"
  3. Press and try to move.
  4. Notice you are still stalking, despite not holding the button

Screenshots

No response

Wisemonster commented 1 year ago

Ok, after a ittle bit of testing, it's examine being bound to the same key as hold to sprint/stalk that is causing the issue.