tgstation / TerraGov-Marine-Corps

TGMC: TerraGov Marine Corps, a SS13 mod
GNU Affero General Public License v3.0
154 stars 805 forks source link

Underbarrel flashlights don't work properly #16009

Open Zangeiti opened 1 month ago

Zangeiti commented 1 month ago

Description

On map LV759, attempting to toggle on an underbarrel flashlight will only provide a minuscule light source on yourself

dreamseeker_wkIX3UHrEN

Test Merges

#15886: 'Makes OBs cost the same (solid fuel-wise)' by yyzsong at commit 11c7ce4ee9 #15894: 'Submerging refactor' by Lumipharon at commit 33e756c5d8 #15936: 'Vali Spear: The Return' by Barnet2 at commit 1a7a153ce1 #15935: 'New Map: LV-759' by RipGrayson at commit fa8e089c21

Reproduction Steps

Go on LV759, get a gun with an underbarrel flashlight, toggle it on and be disappointed.

Screenshots

No response

CoastalCookie commented 1 month ago

~Upon testing this seems to be a TM bug and not a map bug~

~Probably todo with~ ~https://github.com/tgstation/TerraGov-Marine-Corps/pull/15894~

As upon attempting to reproduce the under barrel lights worked perfectly fine

Okay upon testing it seems to have been a bug that's way more specific then just getting a gun and putting a under barrel light on it both LV759 and Submerging refactor had the light work correctly so something must have happened that broke it instead

Screenshot (144) Screenshot of attempts of trying to reproduce it on the submerging refactor and also LV759

Zangeiti commented 4 weeks ago

~Upon testing this seems to be a TM bug and not a map bug~

~Probably todo with~ ~#15894~

As upon attempting to reproduce the under barrel lights worked perfectly fine

Okay upon testing it seems to have been a bug that's way more specific then just getting a gun and putting a under barrel light on it both LV759 and Submerging refactor had the light work correctly so something must have happened that broke it instead

Screenshot (144) Screenshot of attempts of trying to reproduce it on the submerging refactor and also LV759

It seems like it happens most often when the server chugs hard on highpop or later in the round, causing lighting from underbarrel lights to break like in the example I gave