search

tgstation / TerraGov-Marine-Corps

TGMC: TerraGov Marine Corps, a SS13 mod
GNU Affero General Public License v3.0
154 stars 805 forks source link

Dying in hypersleep #16028

Open CoastalCookie opened 1 month ago

CoastalCookie commented 1 month ago

Description

Dying in hypersleep hides your death icon and makes it basically a round removal if a round goes on for a while you hypersleep and you eventually return with the surprise of the round still going but you died and as such your permanently dead

While for now its expected that people hypersleep to be well permanently round removed but it may be a possible idea to kick people out of hypersleep when they die after https://github.com/tgstation/TerraGov-Marine-Corps/pull/15926 gets merged someday so ghosts can take the body

Test Merges

Server-Side Code Modifications: https://tgstation13.org/parsed-logs/sybil/server_side_modifications.dm

Round ID: 27314 BYOND Version: 515.1633 Server revision compiled on: 2024-06-06T03:19:05+00:00 Master commit: 6c3f139d75ffe9f452f13183ba75fe2fbf9290a4 The following pull requests are currently test merged:

15886: 'Makes OBs cost the same (solid fuel-wise)' by yyzsong at commit 11c7ce4ee9

15936: 'Vali Spear: The Return' by Barnet2 at commit 1a7a153ce1

15935: 'New Map: LV-759' by RipGrayson at commit 1349b1e2d7

Local commit: 8ab5b09b19bc7b4f87dbbdecaa48140f6fe6d08a Server tools version: 6.5.0

Reproduction Steps

Have something that damages you over time for example Internal bleeding Enter cryo Die at some point in time bug reproduced

Screenshots

Video of the glitch https://youtu.be/tCJN3G8ytTo

Screenshot (136)

Screenshot (137)

CoastalCookie commented 1 month ago

This is a very specific scenario so i will later on test it on a private server to explore it in more depth but for now i will leave it as this as this bug is currently unsolvable due to hypersleep being expected to have people close the game anyways and as such making them unrevivable unless if you are extremely lucky

CoastalCookie commented 1 month ago

i realised a fix for this bug would be to have hyper sleep work like stasis bags when the client closes their game making it so they can’t die until they leave hyper sleep and as so never have a issue with dying But i am not a coder so…

CoastalCookie commented 1 month ago

https://youtu.be/tCJN3G8ytTo

A video of the bug (it was over 10mb so it has to be on youtube)

And this also confirms it to be a bug as your not expected to be dead while in cryo