search

tgstation / TerraGov-Marine-Corps

TGMC: TerraGov Marine Corps, a SS13 mod
GNU Affero General Public License v3.0
152 stars 803 forks source link

Killed marines have a chance of being undrainable. Marine death icons also sometimes missing for xenos. #16037

Open AwkwardStereo opened 1 month ago

AwkwardStereo commented 1 month ago

Description

Killed marines have a chance of being undrainable for xenos. Like, normal play, marine falls over dead, but you can't punish it because ??? lmao get fucked ???

Killed marines also sometimes do not have their death icon appear for xenos, leading to their bodies being more difficult to spot and tell if they are drainable (which sometimes they just aren't, lmao).

Test Merges

Round ID: 27336 BYOND Version: 515.1633 Server revision compiled on: 2024-06-07T16:46:29+00:00 Master commit: 703963849f2c22fd22cf4a1a22b97464b65ce84e The following pull requests are currently test merged: #15936: 'Vali Spear: The Return' by Barnet2 at commit 1a7a153ce1 #15935: 'New Map: LV-759' by RipGrayson at commit 6be4a76f64 #15926: 'Defibrillator refactor, NPCs/disconnected players rework' by Neocloudy at commit 635cde74a4

Reproduction Steps

I have no fucking idea and I was too busy xalding out of my mind because we lost to this shit.

Screenshots

No response

CoastalCookie commented 4 weeks ago

I suspect this is caused by #15926: 'Defibrillator refactor, NPCs/disconnected players rework' by Neocloudy at commit 635cde74a4 As during normal gameplay this has never happened I will check this out when i get the time

Nevermind it was already discovered by someone else Apparently people who DNR become undrainable so basically person dies and manually dnr's themselves (due to the TM)

Ragecrabbo commented 4 weeks ago

Can confirm this has happened to me as marine right after dying. Did not go DNR as other marines were closeby but xenos complained about not being able to drain me.