tgstation / TerraGov-Marine-Corps

TGMC: TerraGov Marine Corps, a SS13 mod
GNU Affero General Public License v3.0
163 stars 820 forks source link

Gorger Rebalances & Visual Effects #16588

Closed Sun-Soaked closed 3 weeks ago

Sun-Soaked commented 1 month ago

About The Pull Request

Visual effects:

Oppose

https://github.com/user-attachments/assets/d6feeb21-4530-4383-9255-6f3d3098abdf Shatter is marine stun range, particles are xeno heal range.

Transfusion https://github.com/user-attachments/assets/4657bcbe-0797-441b-a062-fec02f10b7b7

Psylink beam is identical to drone psylink, so I didn't grab any additional footage

Why It's Good For The Game

Drain had a habit of instantly cancelling itself if the gorger in question was undergoing movement. This brief immobilize makes this much more difficult to immediately cancel, which should make it easier for most gorgers to pull off drains on moving targets.

Oppose is a slightly funky primordial ability, especially when compared to the explicitly caste-improving balancing of other primordials. It could use a buff so it's more "competitive" with base gorger skills in terms of blood use. This pr reduces the relative cost somewhat (from costing 6 infusions worth of blood to 5) and makes it more rewarding to go for a slam on top of a marine, since it's pretty challenging to pull it off & rn there's very little incentive Did you know oppose healed gorger? I didn't, it wasn't mentioned anywhere in code or descs, but it does. So I changed the desc to reflect how oppose actually works.

I have other issues with Psylink(mainly that almost any situation where you'd use it would be better suited by just Going In yourself) but this should at least make it easier for players to use it effectively, while curbing the power slightly by making it fail more quickly.

It can be difficult to figure out how to use gorger properly (it has something of a rep as a niche for experienced players/noob trap) and the visual feedback for some abilities should make it slightly more clear how they work. Slight balance nudge & the drain fix should encourage more use of gorger and experimentation with it's abilities, since it's an interesting caste that deserves to be used more.

(I may eventually have to nerf infusion, depending on how much this boosts gorger usage. We'll see how that turns out)

Changelog

:cl: add: the Gorger Psylink, Infusion, and Oppose abilities on Gorger now have vfx. qol: gorger drain now briefly stops gorger, preventing them from instantly cancelling it on accident. balance: buffs oppose, increasing the damage and stagger on a direct marine hit and reducing the cost slightly. balance: gorger psylink now activates more quickly, but is cancelled more easily (at 50% gorger hp instead of 20%) imageadd: A vfx shatter effect for Oppose. spellcheck: removed repeated "Into the ground" from chat feedback on oppose. /:cl:

Sun-Soaked commented 1 month ago

does anyone know why 96x96.dmi lost size when I added something to it?

Arturlang commented 1 month ago

does anyone know why 96x96.dmi lost size when I added something to it?

maybe because upstream had more data in it? See and check

Sun-Soaked commented 1 month ago

does anyone know why 96x96.dmi lost size when I added something to it?

maybe because upstream had more data in it? See and check

none of the upstream sprites are missing from this one. idk what's going on

yyzsong commented 1 month ago

this pr questions my judgement and thus I am not in favour of it.

(just a note for people who don't like to do math: this makes oppose require hitting 6 xenos to break even instead of 8)

github-actions[bot] commented 1 month ago

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Sun-Soaked commented 3 weeks ago

waow

Sun-Soaked commented 3 weeks ago

I did the ahh. autodoc btw