tgstation / TerraGov-Marine-Corps

TGMC: TerraGov Marine Corps, a SS13 mod
GNU Affero General Public License v3.0
164 stars 821 forks source link

Fixes godmode puppet bug #16734

Closed Aporhtonoma closed 1 week ago

Aporhtonoma commented 1 week ago

About The Pull Request

apparently applying warding pheromones AND THEN giving your puppet a warding blessing makes it reach god mode due to the blessing being multiplicative. This changes that to it a being flat bonus and should kill this bug forever

Why It's Good For The Game

image this never happens again.

Changelog

:cl: fix: fixes puppets ridiculous armor ratings if warding pheromones were applied before it got warding blessing /:cl:

Aporhtonoma commented 1 week ago

bruh, what is this shitcode? Also you closed the revert pr while this isn't even merged yet.

I have no idea I changed the code as little as I could because I did not wanna break something. Bonus armor is additive and the final values I left unchanged since I dint wanna touch balance

as for the revert pr... Im stupid

Aporhtonoma commented 1 week ago

What are these cursed numbers and why do puppets need exactly 105.84 extra melee armour?

this cursed numbers are the result of (the original armor of the puppet)aurastrength2.7 and the 105.84 is 14(melee armor)2.8(aurastrength)2.7 Im really doing my best to not make this a balance pr :(