Add EditorConfig to enforce code styling prefs + code cleanup pass - Githubissues

tgstation / Tgstation.Server.ControlPanel

Official client for tgstation-server

GNU General Public License v3.0

7 stars 11 forks source link

Add EditorConfig to enforce code styling prefs + code cleanup pass #69

Closed bobbah closed 3 years ago

bobbah commented 3 years ago

Added a default EditorConfig for .NET and modified the rules to use tabs for preferred indentation (as requested by Cyberboss).

Through suggestions, manually applied...

Name simplification on solution (byebye String!)
Move switch blocks to switch expressions where appropriate
Remove unnecessary suppression of errors that no longer are raised
Simplify substrings with new string indexing
Pass cancellationToken when available from calling method

After this, used code cleanup to enforce indentation as tabs as well as the following rules...

Format document
Sort usings
Remove unnecessary usings
Remove unnecessary casts
Apply file header preferences
Sort accessibility modifiers
Make private fields readonly when possible
Apply language/framework type preferences

This PR relies on changes from #68, and should be merged after.

Cyberboss commented 3 years ago

I trust you bobbah