tgstation / Tgstation.Server.ControlPanel

Official client for tgstation-server
GNU General Public License v3.0
7 stars 11 forks source link

Bad use of IsVisible XAML attribute in Avalonia #70

Closed bobbah closed 3 years ago

bobbah commented 3 years ago

As seen in MainView.xaml, we are currently using the IsVisible attribute to control rendering of different pages. The problem is that this doesn't stop them from being handled with their bindings eagerly loaded, rather it just hides them.

This probably degrades performance significantly throughout the entire application, and causes an insane amount of errors to be logged from Avalonia during ANY UI interaction.

Related GitHub issue on the Avalonia repo can be found here: https://github.com/AvaloniaUI/Avalonia/issues/1434