search

tgstation / Tgstation.Server.ControlPanel

Official client for tgstation-server
GNU General Public License v3.0
7 stars 11 forks source link

`Deploy Code After Changes` force queues a deployment even if repo operations fail #87

Open AffectedArc07 opened 2 years ago

AffectedArc07 commented 2 years ago

image

Kinda a pain in the ass UX wise

Cyberboss commented 2 years ago

Not sure if this is fixable. The idea is we rely on the server side to "queue" the two jobs (deploys can't happen while a repo job is running). This allows the A then B behavior to happen if you close the control panel.

The alternative is to have the panel wait until the repo operation is complete before sending the deploy job. Which is fine, but you miss out on the "async" benefit

Cyberboss commented 2 years ago

To get perfect behavior we'd have to add server side logic for this, which wouldn't be the end of the world honestly

AffectedArc07 commented 2 years ago

Not sure if this is fixable. The idea is we rely on the server side to "queue" the two jobs (deploys can't happen while a repo job is running). This allows the A then B behavior to happen if you close the control panel.

The alternative is to have the panel wait until the repo operation is complete before sending the deploy job. Which is fine, but you miss out on the "async" benefit

I think we lost out on the async benefit anyway when you realise this panel fully locks up every time a web request is made, which is great when your TGS4 host is on the other side of the planet, as well as GitHub being on the other side of the planet.