search

tgstation / dev-cycles-initiative

Hub for tracking issues in the Dev Cycles Initiative
1 stars 0 forks source link

/world/incrementMaxZ is inefficient #24

Open Mothblocks opened 1 year ago

Mothblocks commented 1 year ago

incrementMaxZ increases the max-z by 1 every time its called. This is twice as slow as incrementing the max-z with the number of z-levels we expect to use. That number should be precalculated and preallocated, then go back to incrementing when that is done.

Mothblocks commented 1 year ago

There's a chance that all the News will end up being worse for visible lag, definitely run a 50/50 test merge to see.

LemonInTheDark commented 1 year ago

you sure about this? I swear I profiled it and it was a static cost

Mothblocks commented 1 year ago

botbus implies yes, but like I said I still don't know about New