tgstation / rust-g

Rust based libraries for tgstation
MIT License
28 stars 100 forks source link

Switch over from libgit2 to gix for git.rs #127

Closed ZeWaka closed 11 months ago

ZeWaka commented 1 year ago

Removes the dependency on libgit2, switches to gitoxide/gix/git-repository instead.

rustg_git_revparse working identically, for rustg_git_revparse("HEAD") of my local: image rustg_git_commit_date on that same commit: image

Advisory: This does add a lot of small internal dependencies to the git-repository crate, so the final release binary goes from 6.55MB to 7.12MB, an increase of 0.57MB. I aim to make up this difference elsewhere (see #128, saved 1.56MB there), as I don't see any immediate ways to pare down this crate (the discover fn is in the base crate, the rest seem to be in deps we could use).

Mothblocks commented 1 year ago

Every time you say libshit2 I have literlaly no idea what you mean and have to check

optimumtact commented 1 year ago

, so the final release binary goes from 7.14MB to 7.55MB, an increase of 0.41MB.

literally who cares lmao I have 4 terabytes of disk space

ZeWaka commented 1 year ago

, so the final release binary goes from 7.14MB to 7.55MB, an increase of 0.41MB.

oranges: literally who cares lmao I have 4 terabytes of disk space

see:

[6:58 PM] mothblocks: make sure it doesnt bloat our file size too much [6:58 PM] mothblocks: remembert that loading a dll contributes to the memory limit [6:58 PM] mothblocks: which isnt as big of a deal as it used to be [6:58 PM] mothblocks: but im sure someone willbe p issed off at me eventually about it

Mothblocks commented 1 year ago

That was in reference to statically linking an ssl lib btw

optimumtact commented 1 year ago

who would be pissed what a load of horse shit

Mothblocks commented 1 year ago

Idk i just dont like getting yelled at by mso

optimumtact commented 1 year ago

protip fo rdealing with mso just lie and say I did it

ZeWaka commented 1 year ago

need to switch to gix package name

optimumtact commented 1 year ago

finish ur shit

ZeWaka commented 1 year ago

This isn't a super big problem anymore since libgit2 doesn't require libssl1 (mysql still does unfortunately) anymore it seems. This PR could go either way.

optimumtact commented 1 year ago

replace mysql with postgresql

ZeWaka commented 11 months ago

Closing due to redundant