tgstation / rust-g

Rust based libraries for tgstation
MIT License
28 stars 100 forks source link

Redis pubsub disconnects in V3.1.0 #172

Open AffectedArc07 opened 6 months ago

AffectedArc07 commented 6 months ago

This now occurs when using 3.2.0, whereas in 3.0.0 it didn't

image-23-1.png

Reportedly occurs during high load procs such as round setup before start.

ZeWaka commented 6 months ago

Could you test using 3.1.0 to see which release broke it? I don't recall any changes I've made that should've broke it - Goon runs 3.1.0 in production currently.

ZeWaka commented 6 months ago

Maybe related to #173

AffectedArc07 commented 6 months ago

Maybe related to #173

Unsure, we're on windows.

AffectedArc07 commented 6 months ago

Disregard, didnt build right.

Testing when I can.

AffectedArc07 commented 6 months ago

Could you test using 3.1.0 to see which release broke it? I don't recall any changes I've made that should've broke it - Goon runs 3.1.0 in production currently.

@ZeWaka Confirmed also broken on 3.1.0

AffectedArc07 commented 6 days ago

Update.

This broke on releases after 0.23.0 of the rust redis crate. Below is the content from Cargo.lock to allow it to work again.

[[package]]
name = "redis"
version = "0.23.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3ea8c51b5dc1d8e5fd3350ec8167f464ec0995e79f2e90a075b63371500d557f"
dependencies = [
 "combine",
 "itoa",
 "percent-encoding",
 "ryu",
 "sha1_smol",
 "url",
]

We have a patch on our fork to counteract this, but a proper fix will be needed here sometime.

optimumtact commented 5 days ago

What does redis say when it's disconnecting it?

AffectedArc07 commented 5 days ago

What does redis say when it's disconnecting it?

All these image

optimumtact commented 5 days ago

No I mean in the kern.log for the server, which is what is forcibly hanging up the connections.

optimumtact commented 5 days ago

or the redis log of the server

AffectedArc07 commented 5 days ago

No I mean in the kern.log for the server, which is what is forcibly hanging up the connections.

Lemme dig

Edit - We dont have any