search

tgstation / tgstation-server-webpanel

React application for interacting with tgstation-server
GNU Affero General Public License v3.0
10 stars 11 forks source link

Refreshing the page after authenticating through OAuth logs you out #138

Open Crossedfall opened 1 year ago

Crossedfall commented 1 year ago

Repro steps:

  1. Log in using OAuth (Keycloak in our case)
  2. Refresh page

Expected: The page refreshes and you go about your day Actual: You are pushed back to the login page

I can confirm that the auth-session has not expired-- as attempting to re-auth through keycloak instantly logs you back in.

Crossedfall commented 1 year ago

Navigating between pages is fine. It's only when you refresh any given page.

Cyberboss commented 1 year ago

With https://github.com/tgstation/tgstation-server-webpanel/commit/da12029e2d1839e97924f98b2dddbb798221c38d the token will persist as long as it can. Kicking you out once it expires.

Crossedfall commented 1 year ago

Doesn't seem to be the case. Refreshing still logs me out on version 4.16.0