tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.72k stars 4.76k forks source link

Self-Respiration doesn't work (also maybe toxin filter) #10698

Closed Marflowerose closed 8 years ago

Marflowerose commented 9 years ago

Got 2 viruses with Self-Respiration, 5/5 both, got steady GROWTH of suffocation damage in space, verified by Shadowlight213. This is different from the usual 1 suffocation damage that goes away.

Edit. Also found out geneticist had toxin damage that the regenerative viruses never cured, despite having 3 toxin filters

Edit 2. The geneticist had all 3 viruses but possibly dying during the round and being defibbed may have fucked over the viruses

WJohn commented 9 years ago

Might be related in that breathing from an air tank is somewhat broken right now.

newfren commented 9 years ago

Can confirm, was the geneticist. I definitely had 22 tox damage in my system and checked several times to make sure all 3 viruses were 5/5.

phil235 commented 9 years ago

Can't reproduce the bug with toxic filter.

But I could reproduce the bug with self respiration, you take oxy damage.

So there might be two different bugs here.

Marflowerose commented 9 years ago

I don't know what caused the toxin damage on @newfren but as I recall, he died, got defibbed, still had the viruses 5/5 and some time after that I got note about the toxin damage that didn't heal.

newfren commented 9 years ago

It was actually also present before I got defibbed. The 22 tox damage was there before I was defibbed, and it looks like the diseases just weren't doing anything after I was defibbed.

ghost commented 9 years ago

Pretty sure self respiration heals oxy damage fast so this is probably a bug with goofchem

Or virus stacking, if self respiration was in your first virus it may have gotten overwritten by the 2 other viruses you stacked on top of it

Pretty sure that was a bug that got patched forever ago though

phil235 commented 9 years ago

The problem isn't the salbutamol reagent (that self respration symptom is supposed to inject), it works fine if you inject yourself manually and then go in space. You take oxy damage but very slowly, unlike when I tested the selfRespiration virus.

I tested SR virus again and it worked as intended, odd...

@Marflowerose How fast was the oxy damage rate? a slow increase is intended by the code it seems.

Marflowerose commented 9 years ago

It seemed to be approximately 1 damage every 1-2 seconds and I didn't notice it going down at any point, like how brute/burn/toxin fluctuates normally with viruses when spacewalking nude.

Also remotely related: Earlier that round I used vaccine to cure one of my viruses that I had become just a carrier for (annoying feature) and replaced it with ToxFil, ToxCom, Stimulant and DAA. I still had two viruses 5/5 with self-respiration.

apuh3 commented 9 years ago

It's possible to change your metabolism rate ingame. Maybe that had something to do with it.

phil235 commented 9 years ago

@Marflowerose the viruses only pumps you with salbutamol when you don't have any in you, so having one self-respiration virus or three has the same effect. I think it is working as intended. The only potential issue is how much oxy damage you take per life cycle in an airless environment, making you still get a little oxy damage even with salbutamol (I changed the gasping oxy damage value a couple months ago during my life refactor I think) so it's an easy fix.

Marflowerose commented 9 years ago

Yeah I know Self-Respiration, Ocular Repair and Stimulant don't stack but I tend to keep Self-Respiration on all viruses since there's no telling which one gets carrier mode on and never goes above 1/5.

tkdrg commented 8 years ago

@LanCartwright recently reported being unable to reproduce this. Closing unless someone else manages to reproduce it.