search

tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.72k stars 4.75k forks source link

Laws on intelicard didn't update properly after AI reconstruction #4572

Closed Lobachevskiy closed 10 years ago

Lobachevskiy commented 10 years ago

http://i.imgur.com/gR1LXV9.png So, AI had ion law, I'm not sure whether it was from hacked upload board or Ion storm, but I don't remember the event message ever coming up. AI was killed, retrieved in intelicard and reconstructed. After that it claimed to be Asimov, RD reconstruction console showed Asimov (as seen on the screenshot), but intelicard still showed supposedly nonexistent ion law in addition to regular Asimov.

For the record, I tried putting AI back into RD computer and into intelicard multiple times, to no end.

Sybil, revision https://github.com/tgstation/-tg-station/commit/d5153bc6a4c15a462afc4ec952f2c14ba6c4c329

Dorsisdwarf commented 10 years ago

Ion storm, for the record. It was not announced. Roughly 20 minutes between death and carding/revival. Multiple ghosting/re-entering body in between death and carding.

theOperand commented 10 years ago

It'd be really cool if somebody could try to reproduce this.

PKPenguin321 commented 10 years ago

Just attempted to reproduce it on a private server. Seems like what he described worked, however upon assuming control of the AI it still had the ion law. Either the AI in his round was lying or something changed here.

aicardbug

aicardbug2

But then I gave it a freeform law as a test and it did show up on the RD's computer, but still not the ion law.

aicardbug3

So maybe this is an issue of the RD's console not displaying ion laws? I also switched back into the AI after that and it still had both the ion law and the test law. I wouldn't know, I have no coding experience at all, but hopefully this helped.

theOperand commented 10 years ago

Did you look at the laws datum and the admin show laws thingie?

PKPenguin321 commented 10 years ago

Sorry for getting back so late, I don't really frequent github. I did not confirm laws through commands, but just now I got the latest /tg/ revision and tried it again, this time doing the admin show laws secret command at every step. So as to not clog this page further, images are here: http://imgur.com/a/3C4yr

Again, hope this helps.