tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.7k stars 4.92k forks source link

Cutting out the floor beneath you doesn't drop you on multi-z #49685

Closed Ryll-Ryll closed 1 hour ago

Ryll-Ryll commented 4 years ago

Round ID: 131402

Testmerges:

49065: 'Disable library machine uis' by optimumtact at commit f261fc0b45

49579: '[READY]Return of the dwarves Mk.2 : Oranges approved - ashlizards removed ' by EdgeLordExe at commit 1d517bd8b5

49476: 'Adds tackling (VIDEO INSIDE)' by Ryll-Ryll at commit 32fad5b299

Reproduction:

dreamseeker_2020-03-02_22-00-08.png Step 1: Be on the not-first floor Step 2: Remove the floor you're standing on (say, a catwalk) Step 3: Hover as long as nothing moves you

HomocidlePancakes commented 4 years ago

This isn’t an issue exclusive to multi-z. If you stand on a plasmeme and take off his suit, you won’t be set on fire. Probably there are more cases that we don’t know about.

Dennok commented 4 years ago

Change head to "Cutting out the catwalk beneath you doesn't drop you on multi-z" Or test it with RCD and real floor/plating.

PKPenguin321 commented 4 years ago

Perhaps updating a turf should call Crossed() on its contents

Dennok commented 4 years ago

Perhaps updating a turf should call Crossed() on its contents

I think yes.

optimumtact commented 4 years ago

I seem to remember we tried that, and it caused a bunch of bugs that just were not worth the hassle of fixing.

PKPenguin321 commented 4 years ago

Crossed() might be too general then. Is there an individual proc that handles falling? Call that

Ryll-Ryll commented 4 years ago

Is there any reason you can't just call zFall() on the turf for each of the contents

PKPenguin321 commented 4 years ago

Yeah, you get it

cacogen commented 4 years ago

@Dorsisdwarf you should add this one to the multi-z stations milestone instead

projectkepler-ru commented 2 months ago

@optimumtact this is no longer applicable

Sealed101 commented 1 hour ago

^ tested, can no longer cosplay looney toons gravity