Genturf appears after explosion

redguy999 commented 3 years ago

Reporting client version: 513.1536

Round ID:

157588

Testmerges:

Scanner gates now have wires/interact with signalers.

Reproduction:

activate the bomb in the lavaland syndicate base
wait/make it go boom
be confused at odd green tiles.

ghost commented 3 years ago

this had to do with the syndi base not having baseturfs setup correctly supposedly

Fikou commented 3 years ago

the same thing happens with the seed vault

dragomagol commented 3 years ago

Apparently this is still an issue (it worked on local I promise)

timothymtorres commented 3 years ago

I'm linking #41147 since it seems to be somewhat relevant.

antrophoss commented 2 years ago

it still happens on lavaland syndie base when potassium-water bombing

LemonInTheDark commented 2 years ago

The issue is this

gen turfs are just markers for map generation logic. they normally get deleted by map generation, as a process of their areas loading in their preferred map generator https://github.com/tgstation/tgstation/blob/27946f516dd77faa071576499bb700c6fa22fbab/code/controllers/subsystem/mapping.dm#L94-L99

This is what should happen. However, we're running ruin generation before we do this. the ruins place themselves on top of the genturfs, and you get this.

This order was introduced by https://github.com/tgstation/tgstation/pull/56472/files#diff-5bf90fa989ac23e6b2eafe1ed3f018e1c59fb65a348c0982a34cc60732770380R121 in an attempt to solve issues with map generated things (monsters and spawners and such) being spawned inside ruins.

I get the feeling what we really want here is something like this

ruins decide where they want to be
map generates, doing only basic generation in ruin cordoned spaces
ruins load in on top of that space, doing ruin things

Then again, this has issues with the borders of ruin generation. Maybe we need to separate spawning in effects and spawning in the shape of the level into two steps. I'm honestly not sure.

It's annoying.