tgstation / tgstation

The /tg/station branch of SS13.
https://www.tgstation13.org/
GNU Affero General Public License v3.0
1.72k stars 4.77k forks source link

AI has null laws ; contact a coder! #69812

Open iprice opened 2 years ago

iprice commented 2 years ago

Reporting client version: 514.1585

Round ID:

190175

Testmerges:

Reproduction:

Don't know how to reproduce this.

Came to light due to a slaved, synced borg, connected to a malf AI, failing to inherit its law 0.

Doing a quick check laws confirmed the borg is mastered but does indeed lack its law 0. More concerningly the AI its self reports no laws and gives the error about laws being null and to report this to coding.

Check-AI-Laws: image

Confirmation the borg is both mastered and lawsynced. image

Only obvious thing I found in runtime log (without knowing what keywords i'm really looking for beyond ckeys and 'law') [2022-09-09 18:38:29.189] ## TESTING: GC: -- [0x21068039] | /datum/ai_laws was unable to be GC'd -- I dunno if there should be a ai_laws getting GCed (presumably via being scheduled for deletion somewhere?) around here but its a bit deeper in the code than I usually go.

Around the 35-40 minute mark an AI law reset card is used on the AI which reverts them to a pure asimov lawset (the AI is definately malf, has malf antag in TP, objectives, is hacking APCs, the works). Later on the laws become null again (?)

ShizCalev commented 2 years ago

69771 likely related

iprice commented 1 year ago

Another example in round 200124, malf AI, ends up creating a ton of borgs, who dont inherit a law 0 due to the AI having null laws (so I assume that part just runtimes).

AI [Zemsta]/(ANTON-I)'s laws:
[Zemsta]/(ANTON-I)'s laws are null?? Contact a coder.
iprice commented 1 year ago

Round 214154

AI Toshaa/(L.U.M.I.N.A.T.E.)'s laws:
Toshaa/(L.U.M.I.N.A.T.E.)'s laws are null?? Contact a coder.